Skip to content

GUI: standardize action button labels by changing "New..." to "Add..." #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

GUI: standardize action button labels by changing "New..." to "Add..." #49

wants to merge 1 commit into from

Conversation

@AAClause
Copy link
Member

  • Changed button labels from "&New..." to "&Add..." to maintain consistency with other action buttons that use verbs (e.g., Edit and Delete), and to prevent translation complications related to gender, such as "nouveau" and "nouvelle" in French.
  • Updated the description hint for empty lists in the Criteria Editor from "Press alt+n" to "Press Alt+A."
  • Modified the label for alternatives from "&Alternatives" to "A&lternatives" to avoid conflict with the "&Add" shortcut key.
  • Renamed the event handler from onNewCriteria to onAddCriteria for better alignment.

@AAClause
GUI: standardize action button labels by changing "New..." to "Add..."
6c75576 
- Changed button labels from "&New..." to "&Add..." to maintain consistency with other action buttons that use verbs (e.g., Edit and Delete), and to prevent translation complications related to gender, such as "nouveau" and "nouvelle" in French.
- Updated the description hint for empty lists in the Criteria Editor from "Press alt+n" to "Press Alt+A."
- Modified the label for alternatives from "&Alternatives" to "A&lternatives" to avoid conflict with the "&Add" shortcut key.
- Renamed the event handler from `onNewCriteria` to `onAddCriteria` for better alignment.
@JulienCochuyt
Copy link
Member

@AAClause wrote:

consistency with other action buttons that use verbs (e.g., Edit and Delete),

I agree this is an outrageous lexical discrepancy, but we - my fellow wordsmith - have lost this war in the early 80s.
Have a look at the two first entries in any standard "File" menu…

and to prevent translation complications related to gender, such as "nouveau" and "nouvelle" in French.

I would advocate pgettext is the preferred way to go in such case.
In the very case your pointing out, I tend to refer to this list as containing "Alternative Criteria Sets", which translates to "Jeux de critères alternatifs" which is of masculine grammar gender.

Hence, -1 for me.

@AAClause
Copy link
Member Author

@JulienCochuyt Yes but... the NVDA codebase tends to favor the term "Add" over "New".

nvda/source/gui$ grep -ri -E "['\"]&(add|new)['\"]" --include='*.py' .
./configProfiles.py:            newButton = buttonHelper.addButton(profilesListBox, label=_("&New"))
./inputGestures.py:             self.addButton = bHelper.addButton(self, label=_("&Add"))
./settingsDialogs.py:           addButton = bHelper.addButton(self, label=_("&Add"))
./speechDict.py:                        label=_("&Add")

@frederic-brugnot We'd love to hear your thoughts to help settle this discussion! 😀

@JulienCochuyt JulienCochuyt changed the base branch from dev to develop March 4, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frederic-brugnot frederic-brugnot Awaiting requested review from frederic-brugnot

@JulienCochuyt JulienCochuyt Awaiting requested review from JulienCochuyt

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AAClause @JulienCochuyt